Use aggregated reading for 1D selections. #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aggregating scattered reads was implemented in * 8366465 adds bulkRead, * a7d1453 for 2D selections. However, it was only used for edge indexes. We measured the performance on an HDD and SSD for random access patterns with different streak lengths. We found that for all cases, including streak length of 1, using bulkRead was preferrable over both `0.1.24` (using `HighFive::ElementSet`) and `0.1.29` (using `HighFive::HyperSlab`). We investigated if aggregating multiple pages was beneficial and found that it was not.
|
Impressive. |
mgeplf
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregating scattered reads was implemented in
However, it was only used for edge indexes. We measured the performance on an HDD and SSD for random access patterns with different streak lengths. We found that for all cases, including streak length of 1, using bulkRead was preferrable over both
0.1.24(usingHighFive::ElementSet) and0.1.29(usingHighFive::HyperSlab).We investigated if aggregating multiple pages was beneficial and found that it was not.