Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::filesystem #372

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Use std::filesystem #372

wants to merge 2 commits into from

Conversation

matz-e
Copy link
Member

@matz-e matz-e commented Sep 27, 2024

Recent versions of nlohmann/json fail to compile with the
ghc::filesystem shim. Bump C++ stdandard, require a minimum Catch2
version, too.

Recent versions of nlohmann/json fail to compile with the
ghc::filesystem shim.  Bump C++ stdandard, require a minimum Catch2
version, too.
@musicinmybrain
Copy link

This still seems like a good idea.

I tried this with Catch2 3.8.0, and I also needed to change each #include <catch2/catch.hpp> to #include <catch2/catch_all.hpp>. Then I needed to link the unittests target with Catch2::Catch2WithMain instead of Catch2::Catch2. After that, it seemed to work fine.

Are you planning to open a new version of this PR at https://github.com/openbraininstitute/libsonata at some point?

@matz-e
Copy link
Member Author

matz-e commented Feb 3, 2025

@musicinmybrain thank you for testing!

Are you planning to open a new version of this PR at https://github.com/openbraininstitute/libsonata at some point?

I'm no longer involved with the associated project(s) - still get and respond to notifications when I can. But I am not going to port any PRs. Feel free to take this over!

The test logs expired, and I'm wondering if a switch to a newer manylinux would be required to get full support for std::filesystem à la neuronsimulator/nrn#1963 (comment) (mentions that newer images ship with GCC 14).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants