Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update distribution paths #156

Merged
merged 4 commits into from
Jul 10, 2024
Merged

update distribution paths #156

merged 4 commits into from
Jul 10, 2024

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Jul 9, 2024

No description provided.

@ilkilic ilkilic self-assigned this Jul 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.45%. Comparing base (8d5b0ab) to head (ef43951).
Report is 45 commits behind head on main.

Files Patch % Lines
bluepyemodel/access_point/forge_access_point.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   60.07%   53.45%   -6.63%     
==========================================
  Files         109      122      +13     
  Lines        7838     9668    +1830     
==========================================
+ Hits         4709     5168     +459     
- Misses       3129     4500    +1371     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilkilic ilkilic requested a review from AurelienJaquier July 10, 2024 07:33
Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! While you are at it, could you also use self.download_directory in nexus.py line 138 so that we create the right folder?

Also, do you think it would be better to also pass iteration (we can get it directly from metadata_dict) to dump_json_and_get_distributions? It's just a suggestion, you don't have to implement it if it is too complicated / if you don't think it is a good idea.

@ilkilic
Copy link
Collaborator Author

ilkilic commented Jul 10, 2024

Good catch, I have updated line 138 so it uses self.download_directory.

I didn't pass iteration to dump_json_and_get_distributions because it is also called by update_distribution and this function doesn't have access to metadata_dict

@ilkilic ilkilic merged commit 41f9090 into main Jul 10, 2024
6 checks passed
@ilkilic ilkilic deleted the fix-json-distr-path branch July 10, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants