Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default value for segx param, improve docs vcs: #minor #127

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Add default value for segx param, improve docs vcs: #minor #127

merged 3 commits into from
Feb 5, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Feb 5, 2024 •
edited
Loading

Addresses the issues mentioned in #126.

  • adds more information on the segx param
  • adds default value for segx in add_voltage_recording and get_voltage_recording

@anilbey anilbey changed the title Add default value for segx param, improve docs Add default value for segx param, improve docs vcs: #minor Feb 5, 2024
@anilbey anilbey merged commit b87d55e into main Feb 5, 2024
10 checks passed
@anilbey anilbey deleted the segx-param branch February 5, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanoantonel stefanoantonel stefanoantonel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anilbey @stefanoantonel