Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/error deletion #184

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bugfix/error deletion #184

wants to merge 3 commits into from

Conversation

Spencerp34
Copy link
Contributor

Description

Just a fix per Paul's request so our checks pass in GitHub.

Fixes # (issue)

A variable named AuthRequired() was functional but we are experiencing issues with Okta as of late. That lead to breaking code that was out of our control. So our temporary answer was to comment out the code that invoked Okta like authRequired() and this was left

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have removed unnecessary comments/console logs from my code
  • I have made corresponding changes to the documentation if necessary (optional)
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings
  • No duplicate code left within changed files
  • Size of pull request kept to a minimum
  • Pull request description clearly describes changes made & motivations for said changes

Not doing a loom because it's literally just a commented-out variable that isn't in use so the linter isn't mad.

Copy link

@sirakisaias sirakisaias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making sure Okta works is important since authorizing user functionality is crucial before the hand off. The changes made looks good and clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants