Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix bundled plugins on MacOS (#1540) #1541

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

midwan
Copy link
Collaborator

@midwan midwan commented Dec 19, 2024

The bundled plugins of capsimg and floppybridge, were not included in the final app bundle. Furthermore, they need to be signed with the same digital certificate, otherwise MacOS will block them from loading.

Fixes #1540 .

Changes proposed in this pull request:

  • include bundled plugins in a separate folder
  • digitally sign bundled plugins during the build step
  • during the first run, if the plugins directory did not exist, copy the bundled files in there as well.

@midwan

The bundled plugins of capsimg and floppybridge, were not included in the final app bundle.
Furthermore, they need to be signed with the same digital certificate, otherwise MacOS will block them from loading.
@midwan midwan linked an issue Dec 19, 2024 that may be closed by this pull request
@midwan midwan self-assigned this Dec 19, 2024
@solskogen
Copy link
Collaborator

What happens with the plugins in the bundle are newer than the ones in the plugin directory?

@midwan
Copy link
Collaborator Author

midwan commented Dec 19, 2024

@solskogen the way macOS works, no plugins will be allowed to be loaded, unless they were signed with the same certificate the app bundle was. In other words, you can't drop in your own plugins in there. :)

Regarding existing files: only if the directory was missing, will the copy take place. If you already had a Plugins directory in your Amiberry folder, it won't be affected.

@solskogen
Copy link
Collaborator

By default the directory doesn't exist, which means that when a user upgrades Amiberry the newer plugins won't be copied.

@midwan
Copy link
Collaborator Author

midwan commented Dec 19, 2024

If the directory is missing, it will be created and the plugins copied in there.
If it exists, it will be left untouched.

@midwan midwan merged commit 357cb2d into master Dec 19, 2024
28 checks passed
@midwan midwan deleted the 1540-plugins-dont-work-on-macos branch December 19, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins don't work on MacOS
2 participants