-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes xdg-open #65
Fixes xdg-open #65
Conversation
It seems there's some unintended changes included in commit that I didn't notice |
Just something to note: if you disable portals, every distro will instead use the default gnome file picker which looks horrible on things like kde. it's even worse for things like i3 We added it there to fix another issue, I'm not sure what the ideal solution here would be though. From my understanding, portals are the standard way of dealing with cross-DE file pickers I'm not sure what the ideal solution here is. |
Are you on gnome? |
I am on KDE Plasma 5.27 |
What's the issue you're having exactly? Or are you just going through open issues on github and trying to make PRs to fix them If it's the latter, then I apologise for not properly addressing the github issue you're fixing, that's on me |
I have the same issue with them and that fix seems to work for me |
Can you try installing |
Just checking, did that fix your issue? |
Closing because I presume it did, I'll address the related issue as well |
(also I just noticed this PR completely breaks the cargo lock) |
This PR fixes open/browse button using code provided in #52 (comment)