Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes xdg-open #65

Closed
wants to merge 3 commits into from
Closed

Conversation

dreamgineer
Copy link

This PR fixes open/browse button using code provided in #52 (comment)

@dreamgineer dreamgineer marked this pull request as draft August 11, 2024 08:29
@dreamgineer
Copy link
Author

It seems there's some unintended changes included in commit that I didn't notice

@dreamgineer dreamgineer marked this pull request as ready for review August 11, 2024 08:31
@arduano
Copy link
Collaborator

arduano commented Aug 11, 2024

Just something to note: if you disable portals, every distro will instead use the default gnome file picker which looks horrible on things like kde. it's even worse for things like i3

We added it there to fix another issue, I'm not sure what the ideal solution here would be though. From my understanding, portals are the standard way of dealing with cross-DE file pickers

I'm not sure what the ideal solution here is.

@arduano
Copy link
Collaborator

arduano commented Aug 11, 2024

Are you on gnome?

@dreamgineer
Copy link
Author

I am on KDE Plasma 5.27

@arduano
Copy link
Collaborator

arduano commented Aug 11, 2024

What's the issue you're having exactly? Or are you just going through open issues on github and trying to make PRs to fix them

If it's the latter, then I apologise for not properly addressing the github issue you're fixing, that's on me

@dreamgineer
Copy link
Author

I have the same issue with them and that fix seems to work for me

@arduano
Copy link
Collaborator

arduano commented Aug 11, 2024

Can you try installing xdg-desktop-portal-kde and then try again?

@arduano
Copy link
Collaborator

arduano commented Aug 11, 2024

Just checking, did that fix your issue?

@arduano
Copy link
Collaborator

arduano commented Aug 12, 2024

Closing because I presume it did, I'll address the related issue as well

@arduano arduano closed this Aug 12, 2024
@arduano
Copy link
Collaborator

arduano commented Aug 12, 2024

(also I just noticed this PR completely breaks the cargo lock)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants