chore(coins): add broadcast for sol txs in examples #5332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshsp
reviewed
Jan 6, 2025
| ); | ||
| } else { | ||
| console.log('Requesting AirDrop...'); | ||
| const airdrop = await connection.requestAirdrop(mainAccountPublicKey, 1 * LAMPORTS_PER_SOL); |
There was a problem hiding this comment.
This is only applicable for test but not on prod. This should be handle properly if someone want to use script for mainnet account.
There was a problem hiding this comment.
Honestly, I would just remove this from the script and create a separate example for this.
| @@ -34,50 +34,53 @@ const accountsRequired = 5 | |||
|
|
|||
| // For BitGo Test use solana 'devnet' network | |||
| // For BitGo Prod use solana 'mainnet-beta' network | |||
| const network: 'mainnet-beta' | 'devnet' = 'devnet' | |||
| const network: 'mainnet-beta' | 'devnet' | 'testnet' = 'devnet'; | |||
There was a problem hiding this comment.
Why did you add testnet to the networks here, do we support testnet?
| ); | ||
| } else { | ||
| console.log('Requesting AirDrop...'); | ||
| const airdrop = await connection.requestAirdrop(mainAccountPublicKey, 1 * LAMPORTS_PER_SOL); |
| ); | ||
| } else { | ||
| console.log('Requesting AirDrop...'); | ||
| const airdrop = await connection.requestAirdrop(mainAccountPublicKey, 1 * LAMPORTS_PER_SOL); |
There was a problem hiding this comment.
Honestly, I would just remove this from the script and create a separate example for this.
| } | ||
| ], | ||
| "lastScanIndex": 2 | ||
| } |
There was a problem hiding this comment.
This file needs a new line at the end.
mukeshsp
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: COIN-1879