refactor(statics): move out ERC20 tokens to dedicated file to declutter coins.ts #5306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajays97
requested changes
Dec 23, 2024
| import { erc20 } from '../account'; | ||
| import { CoinFeature, UnderlyingAsset } from '../base'; | ||
| import { AccountCoin, erc20 } from '../account'; | ||
| import { MATIC_FEATURES, WETH_FEATURES, ETH_FEATURES } from './coins'; |
There was a problem hiding this comment.
Isn't it supposed to be
Suggested change
| import { MATIC_FEATURES, WETH_FEATURES, ETH_FEATURES } from './coins'; | |
| import { MATIC_FEATURES, WETH_FEATURES, ETH_FEATURES } from '../coins'; |
rv-bitgo
force-pushed
the
WIN-4074-move-out-erc20
branch
from
ec22b29 to
d564d9b
Compare
alebusse
requested changes
Dec 23, 2024
rv-bitgo
force-pushed
the
WIN-4074-move-out-erc20
branch
from
d564d9b to
4805f4f
Compare
rv-bitgo
changed the title
FloBitGo
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Nit: Might want to name this erc20Tokens.ts
| console.log('ETH_FEATURES:', erc20); | ||
| const ETH_FEATURES_WITH_FRANKFURT = [...ETH_FEATURES, CoinFeature.CUSTODY_BITGO_FRANKFURT]; | ||
|
|
||
| const POL_FEATURES = [ |
There was a problem hiding this comment.
Why is this defined in this file and not in features?
|
This PR was closed because it has been stalled for 10 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: WIN-4074