Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(root): remove node 16 #4371

Merged
merged 1 commit into from
Mar 27, 2024
Merged

docs(root): remove node 16 #4371

merged 1 commit into from
Mar 27, 2024

Conversation

zahin-mohammad
Copy link
Contributor

This was missed as part of #4119
TICKET: WP-1100

@zahin-mohammad zahin-mohammad requested review from a team as code owners March 26, 2024 17:42
gianchandania
gianchandania previously approved these changes Mar 26, 2024
@zahin-mohammad zahin-mohammad force-pushed the WP-1100/update-readme branch from 5831d65 to 99c890b Compare March 26, 2024 17:48
@zahin-mohammad zahin-mohammad changed the title docs(root): remove ndoe 16 docs(root): remove node 16 Mar 26, 2024
Copy link
Contributor

@andrew-scott-fischer andrew-scott-fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be <21

DEVELOPERS.md Outdated
@@ -1,7 +1,7 @@
# Requirements

- yarn version 1 (classic)
- node version >=16 and <19
- node version >=18 and <20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- node version >=18 and <20
- node version >=18 and <21

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we support 20, but not 21

Copy link
Contributor

@andrew-scott-fischer andrew-scott-fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed the fix.

@andrew-scott-fischer andrew-scott-fischer dismissed their stale review March 26, 2024 18:15

I'm dismissing my own request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants