Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utxo-lib): add basic utils to utxo-lib #4104

Merged
merged 1 commit into from
Nov 29, 2023
Merged

feat(utxo-lib): add basic utils to utxo-lib #4104

merged 1 commit into from
Nov 29, 2023

Conversation

davidkaplanbitgo
Copy link
Contributor

@davidkaplanbitgo davidkaplanbitgo commented Nov 29, 2023 •
edited
Loading

Be able to parse basic information from a psbt.

BTC-637

@davidkaplanbitgo davidkaplanbitgo marked this pull request as ready for review November 29, 2023 16:56
@davidkaplanbitgo davidkaplanbitgo requested a review from a team as a code owner November 29, 2023 16:56
@davidkaplanbitgo davidkaplanbitgo force-pushed the BTC-637-util-functions-in-utxolib branch from 385e594 to f19e8df Compare November 29, 2023 17:00
OttoAllmendinger
OttoAllmendinger requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@OttoAllmendinger OttoAllmendinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move it into a file transactionAmounts.ts

modules/utxo-lib/src/bitgo/wallet/Psbt.ts Outdated Show resolved Hide resolved
@davidkaplanbitgo davidkaplanbitgo force-pushed the BTC-637-util-functions-in-utxolib branch from f19e8df to 2742e1b Compare November 29, 2023 19:07
OttoAllmendinger
OttoAllmendinger previously requested changes Nov 29, 2023
View reviewed changes
modules/utxo-lib/src/networks.ts Outdated Show resolved Hide resolved
@davidkaplanbitgo davidkaplanbitgo force-pushed the BTC-637-util-functions-in-utxolib branch from 2742e1b to e2e1606 Compare November 29, 2023 19:37
@davidkaplanbitgo davidkaplanbitgo force-pushed the BTC-637-util-functions-in-utxolib branch from e2e1606 to d1cd4a8 Compare November 29, 2023 20:32
@davidkaplanbitgo davidkaplanbitgo merged commit 15ea9f5 into master Nov 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcovar lcovar lcovar approved these changes

@OttoAllmendinger OttoAllmendinger Awaiting requested review from OttoAllmendinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidkaplanbitgo @OttoAllmendinger @lcovar