Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-558: Sylius 2 upgrade #71

Open
wants to merge 78 commits into
base: main
Choose a base branch
from
Open

OP-558: Sylius 2 upgrade #71

wants to merge 78 commits into from

Conversation

jkindly
Copy link

@jkindly jkindly commented Oct 9, 2024

No description provided.

@jkindly jkindly requested a review from senghe October 10, 2024 08:53
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/coding_standard.yml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
src/Resources/config/services/form.xml Outdated Show resolved Hide resolved
src/Resources/config/services/twig/component.xml Outdated Show resolved Hide resolved
tests/Application/config/sylius/2.0/packages/security.yaml Outdated Show resolved Hide resolved
tests/Application/package.json Outdated Show resolved Hide resolved
Copy link
Member

@senghe senghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked this, but I think @mpysiak review is more relevant than my

src/Resources/config/services/twig/component.xml Outdated Show resolved Hide resolved
src/Resources/config/services/twig/component.xml Outdated Show resolved Hide resolved
…delete exclude in build.yml and codding_standard.yml
config/routing/admin/fraud_suspicion.yaml Show resolved Hide resolved
config/services/form.xml Show resolved Hide resolved
- { resource: "resources.yaml" }
- { resource: "services.xml" }
- { resource: "grids.yaml" }
- { resource: "state_machine.yaml" }
- { resource: "workflow.yaml" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sylius 2.0 also supports Winzou. It is not installed by default, but you can still use it. So I would suggest that plugin also support both state machines

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration in customer.xml has been rewritten from winzou to symfony workflow, so why should we keep winzou configuration?

image

doc/installation.md Outdated Show resolved Hide resolved
doc/installation.md Outdated Show resolved Hide resolved
tests/Application/config/packages/_sylius.yaml Outdated Show resolved Hide resolved
tests/Application/config/symfony/6.x/bundles.php Outdated Show resolved Hide resolved
config/services/twig/component.xml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
UPGRADE-2.0.md Show resolved Hide resolved
config/workflow/customer.yaml Show resolved Hide resolved
src/Converter/FraudSuspicionCommonModelConverter.php Outdated Show resolved Hide resolved
src/Processor/AutomaticBlacklistingRulesProcessor.php Outdated Show resolved Hide resolved
src/StateResolver/CustomerStateResolver.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants