Add CI for Go

[aaron-congo]

The CI workflow includes:

• building the client
• running unit tests
• go vet and staticcheck as Go linters
• the lint-rust workflow

[Yury-Fridlyand]

Does CI include linter?

[aaron-congo]

Does CI include linter?

Yep, I added go vet and staticcheck as linters, and I also added the lint-rust step

[congoamz]

I needed to add some arbitrary code here so that lint-rust had something to run against. I tried only adding the copyright, with no actual code, but the lint-rust workflow failed, I think because it wants their to be logic in this file

[congoamz]

I also added this arbitrary test so that the unit test workflow had something to run against

[congoamz]

Apparently this file is recommended to specify ci dependencies (ie dependencies that are not directly required by your code). These dependencies are specified here and in go.mod. If you remove this file the dependencies in go.mod are removed when you run go mod tidy because go detects that they aren't directly required by your code. More info about this here

[aaron-congo]

Couple related questions:

• There's a few dependencies that are required to build the client, create a test report, and lint the Go code. What is the criteria for assessing whether they are okay to use with regard to licensing?
• One recommendation with the Go project layout is to include an internal directory at the root of the Go project that contains private library code. Code in this directory cannot be imported by packages outside the source subtree in which they reside. For the public code that is meant to be used by others, we can either have it at the top level in the go directory or put it in a pkg directory. If we put it in pkg the top-level will not mix Go files and project files like .gitignore, Cargo.toml etc, but the downside is that users will need to include "pkg" in the module import path. Go developers seem to be pretty divided on which way is preferred. More details here

[Yury-Fridlyand]

Can't you use actions/setup-go there?

[aaron-congo]

Maybe? I saw that Java uses setup-java for ubuntu/macos but not for amazon linux so I assumed setup-java did not work on amazon linux and that if it doesn't work for java that it wouldn't for go. But my assumption may be wrong