Java: Add XPENDING command #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Comment on lines
+238
to
+240
| XClaim = 197; | ||
| XAutoClaim = 198; | ||
| XInfo = 199; |
There was a problem hiding this comment.
no - I might as well push all of these
There was a problem hiding this comment.
Why? Those are out of scope, no?
There was a problem hiding this comment.
sure. but somewhat related.
There was a problem hiding this comment.
I wanted to add all the stream commands to get it over with. I can remove the redundant ones if you are strongly opposed. But I'm coding it all at the same time and this will save CI checks in the future.
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/stream/StreamPendingOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/stream/StreamRange.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
Yury-Fridlyand
approved these changes
Jun 25, 2024
acarbonetto
added a commit
that referenced
this pull request
Jun 26, 2024
* Java: Add XPENDING command Signed-off-by: Andrew Carbonetto <[email protected]> * Add @see doc Signed-off-by: Andrew Carbonetto <[email protected]> * Add @see doc Signed-off-by: Andrew Carbonetto <[email protected]> * Update constant name Signed-off-by: Andrew Carbonetto <[email protected]> * Make tests more robust Signed-off-by: Andrew Carbonetto <[email protected]> * Add UT tests Signed-off-by: Andrew Carbonetto <[email protected]> * Update docs for comments Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
added a commit
that referenced
this pull request
Jun 26, 2024
* Java: Add XPENDING command (#389) * Java: Add XPENDING command Signed-off-by: Andrew Carbonetto <[email protected]> * Add @see doc Signed-off-by: Andrew Carbonetto <[email protected]> * Add @see doc Signed-off-by: Andrew Carbonetto <[email protected]> * Update constant name Signed-off-by: Andrew Carbonetto <[email protected]> * Make tests more robust Signed-off-by: Andrew Carbonetto <[email protected]> * Add UT tests Signed-off-by: Andrew Carbonetto <[email protected]> * Update docs for comments Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> * Update for review coments Signed-off-by: Andrew Carbonetto <[email protected]> * Fix merge conflicts Signed-off-by: Andrew Carbonetto <[email protected]> * Remove file Signed-off-by: Andrew Carbonetto <[email protected]> * Update options to point to valkey Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
jduo
pushed a commit
that referenced
this pull request
Jun 28, 2024
* Java: Add XPENDING command (#389) * Java: Add XPENDING command Signed-off-by: Andrew Carbonetto <[email protected]> * Add @see doc Signed-off-by: Andrew Carbonetto <[email protected]> * Add @see doc Signed-off-by: Andrew Carbonetto <[email protected]> * Update constant name Signed-off-by: Andrew Carbonetto <[email protected]> * Make tests more robust Signed-off-by: Andrew Carbonetto <[email protected]> * Add UT tests Signed-off-by: Andrew Carbonetto <[email protected]> * Update docs for comments Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> * Update for review coments Signed-off-by: Andrew Carbonetto <[email protected]> * Fix merge conflicts Signed-off-by: Andrew Carbonetto <[email protected]> * Remove file Signed-off-by: Andrew Carbonetto <[email protected]> * Update options to point to valkey Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command XPENDING