Java: Add the XREADGROUP command
#376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
changed the title
acarbonetto
changed the title
XREADGROUP command
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/stream/StreamReadOptions.java
Show resolved
Hide resolved
| @@ -128,7 +129,10 @@ public static <T> Map<String, T[][]> castMapOf2DArray( | |||
| return null; | |||
| } | |||
| return mapOfArrays.entrySet().stream() | |||
| .collect(Collectors.toMap(Map.Entry::getKey, e -> castArrayofArrays(e.getValue(), clazz))); | |||
| .collect( | |||
| HashMap::new, | |||
There was a problem hiding this comment.
why this change? to accept nulls?
There was a problem hiding this comment.
yes. XREADGROUP returns maps will null values (gross!)
There was a problem hiding this comment.
Do you have a test for that case?
| @@ -753,6 +771,18 @@ private static Object[] streamCommands(BaseTransaction<?> transaction) { | |||
| 1L, // xtrim(streamKey1, new MinId(true, "0-2")) | |||
| OK, // xgroupCreate(streamKey1, groupName1, "0-0") | |||
| OK, // xgroupCreate(streamKey1, groupName1, "0-0", options) | |||
| true, // xgroupCreateConsumer(streamKey1, groupName1, consumer1) | |||
| Map.of( | |||
There was a problem hiding this comment.
nit: you can store this as a variable if it ease reading/debugging
java/integTest/src/test/java/glide/cluster/ClusterTransactionTests.java
Outdated
Show resolved
Hide resolved
GumpacG
approved these changes
Jun 19, 2024
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
java/dev_acarbo_add_xreadgroup_2
branch
from
b3efde5 to
957e012
Compare
acarbonetto
commented
Jun 19, 2024
| @@ -791,6 +791,7 @@ fn convert_to_array_of_pairs( | |||
| value_expected_return_type: Option<ExpectedReturnType>, | |||
| ) -> RedisResult<Value> { | |||
| match response { | |||
| Value::Nil => Ok(response), | |||
There was a problem hiding this comment.
XREADGROUP can/will return null values in the map
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
merged commit 14e3c24
into
java/integ_acarbo_add_xreadgroup
44 checks passed
acarbonetto
added a commit
that referenced
this pull request
Jun 20, 2024
* Java: Add the `XREADGROUP` command (#376) * Add XGROUP CreateConsumer, DelConsumer Signed-off-by: Andrew Carbonetto <[email protected]> * Add XREADGROUP command Signed-off-by: Andrew Carbonetto <[email protected]> * Udpate IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * Fix IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS & merge conflict fix Signed-off-by: Andrew Carbonetto <[email protected]> * Update for review comments Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> * Remove old test from IT suite Signed-off-by: Andrew Carbonetto <[email protected]> * Update xreadgroup docs Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
added a commit
that referenced
this pull request
Jun 20, 2024
* Add XGROUP CreateConsumer, DelConsumer Signed-off-by: Andrew Carbonetto <[email protected]> * Add XREADGROUP command Signed-off-by: Andrew Carbonetto <[email protected]> * Udpate IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * Fix IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS & merge conflict fix Signed-off-by: Andrew Carbonetto <[email protected]> * Update for review comments Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
added a commit
that referenced
this pull request
Jun 20, 2024
* Java: Add the `XREADGROUP` command (#376) * Add XGROUP CreateConsumer, DelConsumer Signed-off-by: Andrew Carbonetto <[email protected]> * Add XREADGROUP command Signed-off-by: Andrew Carbonetto <[email protected]> * Udpate IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * Fix IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS & merge conflict fix Signed-off-by: Andrew Carbonetto <[email protected]> * Update for review comments Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> * Added implementation and incomplete transactiontests * Update test Signed-off-by: Andrew Carbonetto <[email protected]> * Add XACK test Signed-off-by: Andrew Carbonetto <[email protected]> * Remove extra test Signed-off-by: Andrew Carbonetto <[email protected]> * More merge conflict cleanup Signed-off-by: Andrew Carbonetto <[email protected]> * Process review comments Signed-off-by: Andrew Carbonetto <[email protected]> * XACK add failure tests Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Guian Gumpac <[email protected]>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Java: Add the `XREADGROUP` command (#376) * Add XGROUP CreateConsumer, DelConsumer Signed-off-by: Andrew Carbonetto <[email protected]> * Add XREADGROUP command Signed-off-by: Andrew Carbonetto <[email protected]> * Udpate IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * Fix IT tests Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS & merge conflict fix Signed-off-by: Andrew Carbonetto <[email protected]> * Update for review comments Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> * Remove old test from IT suite Signed-off-by: Andrew Carbonetto <[email protected]> * Update xreadgroup docs Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on valkey-io#1599
Adds the XREADGROUP command to Java
TODO: