Java: Add Zmscore command. (Sorted Set Command Group) #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanHalacogluImproving
requested review from
aaron-congo,
jonathanl-bq,
Yury-Fridlyand and
acarbonetto
Yury-Fridlyand
approved these changes
Mar 28, 2024
| @@ -34,6 +34,7 @@ | |||
| * Core: Enabled Cluster Mode periodic checks by default ([#1089](https://github.com/aws/glide-for-redis/pull/1089)) | |||
| * Node: Added Rename command. ([#1124](https://github.com/aws/glide-for-redis/pull/1124)) | |||
| * Python: Added JSON.TOGGLE command ([#1184](https://github.com/aws/glide-for-redis/pull/1184)) | |||
| * Java: Added ZMSCORE command (TODO ADD HERE PR #) | |||
There was a problem hiding this comment.
No need to mention java here, but maybe core. awaiting for AWS team to reply whether we need to record that here or not.
| @@ -135,6 +135,7 @@ enum RequestType { | |||
| Rename = 91; | |||
| DBSize = 92; | |||
| Brpop = 93; | |||
| ZMScore = 94; | |||
There was a problem hiding this comment.
94 is already occupied by a PR on upstream => you will have a conflict
Pick another number. 99 is the next free AFAIK
jonathanl-bq
approved these changes
Mar 30, 2024
SanHalacogluImproving
merged commit 73cd123
into
java/integ_SanH_add_Zmscore
39 of 43 checks passed
SanHalacogluImproving
added a commit
that referenced
this pull request
Apr 10, 2024
SanHalacogluImproving
added a commit
that referenced
this pull request
Apr 10, 2024
acarbonetto
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Java: Add Zmscore command. (Sorted Set Command Group) (#173) * Minor update + remove change log. * Minor documentation update. * Minor IT update. * Rebase + Spotless. * Minor IT test update.
alex-arzola-imp
pushed a commit
that referenced
this pull request
Apr 12, 2024
* Java: Add Zmscore command. (Sorted Set Command Group) (#173) * Minor update + remove change log. * Minor documentation update. * Minor IT update. * Rebase + Spotless. * Minor IT test update.
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Java: Add Zmscore command. (Sorted Set Command Group) (#173) * Minor update + remove change log. * Minor documentation update. * Minor IT update. * Rebase + Spotless. * Minor IT test update.
acarbonetto
pushed a commit
that referenced
this pull request
Jul 11, 2024
…client to properly take received IPs when DNS is expanded #173 Signed-off-by: barshaul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.