Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: miscellaneous CI improvements #139

Merged

Conversation

aaron-congo
Copy link

  • remove workflow_dispatch
  • increase build timeout since other branches are hitting the 20 minute limit
  • set LD_LIBRARY_PATH on ubuntu to fix error seen on other branches where libglide_rs.so could not be found. Note that this problem does not occur on mac
  • remove the test report from CI. On other branches, it was discovered that the command to build the test report could hide build errors when running the tests. The test report also did not allow for logging test outcomes to GH actions at the same time as creating the report.
  • remove unnecessary cargo build for glide-core. glide-core is built automatically when we run cargo build for the wrapper FFI lib.rs, so it was being built twice
  • improve lint output when committed files do not match the required format

@aaron-congo aaron-congo merged commit 87a2a2f into go/integ_acongo_ci_adjustments Mar 18, 2024
11 checks passed
@aaron-congo aaron-congo deleted the go/dev_acongo_ci_adjustments branch March 18, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants