Update readmes for all clients - move common things to one place. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
This was referenced Feb 23, 2024
|
|
||
| Please consider installing the following packages: | ||
|
|
||
| - GCC |
There was a problem hiding this comment.
I guess they didn't add all these to a common file because the idea was that people would prefer to look at the documentation of the specific client. (looking from a different perspective) Maybe, we should ask them if they prefer this before making the PR?
acarbonetto
reviewed
Feb 23, 2024
| @@ -1,5 +1,70 @@ | |||
| # Rust core | |||
|
|
|||
| ## Prerequisites | |||
|
|
|||
| Please consider installing the following packages: | |||
There was a problem hiding this comment.
Remove. It's very polite, but not needed for a prerequisite section. It makes it sound like the following packages are optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
Should be merged ahead of #111 and #112