Java: consolidate transaction tests into a single tests run (valkey-i…

…o#983) * Java: consolidate transaction tests into a single tests run (#91) Signed-off-by: Andrew Carbonetto <[email protected]> * Fix init call for TransactionTests.java Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Bit-Quill · Feb 21, 2024 · 9b11e19 · 9b11e19
1 parent 38544ea
commit 9b11e19
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 143 deletions.
diff --git a/java/client/src/test/java/glide/api/models/ClusterTransactionTests.java b/java/client/src/test/java/glide/api/models/ClusterTransactionTests.java
diff --git a/java/client/src/test/java/glide/api/models/TransactionTests.java b/java/client/src/test/java/glide/api/models/TransactionTests.java
@@ -29,17 +29,23 @@
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
+import java.util.stream.Stream;
 import org.apache.commons.lang3.tuple.Pair;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
 import redis_request.RedisRequestOuterClass.Command;
 import redis_request.RedisRequestOuterClass.Command.ArgsArray;
 import redis_request.RedisRequestOuterClass.RequestType;
 
 public class TransactionTests {
-    @Test
-    public void transaction_builds_protobuf_request() {
-        Transaction transaction = new Transaction();
+    private static Stream<Arguments> getTransactionBuilders() {
+        return Stream.of(Arguments.of(new Transaction()), Arguments.of(new ClusterTransaction()));
+    }
 
+    @ParameterizedTest
+    @MethodSource("getTransactionBuilders")
+    public void transaction_builds_protobuf_request(BaseTransaction<?> transaction) {
         List<Pair<RequestType, ArgsArray>> results = new LinkedList<>();
 
         transaction.get("key");