remove handleStringResponseBinary and use handleGlideStringResponse (v…

…alkey-io#1760) Co-authored-by: Ubuntu <[email protected]>
Bit-Quill · Jul 2, 2024 · 8aae567 · 8aae567
1 parent cc26eb0
commit 8aae567
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/java/client/src/main/java/glide/api/BaseClient.java b/java/client/src/main/java/glide/api/BaseClient.java
@@ -506,10 +506,6 @@ protected String handleStringResponse(Response response) throws RedisException {
         return handleRedisResponse(String.class, EnumSet.of(ResponseFlags.ENCODING_UTF8), response);
     }
 
-    protected GlideString handleStringResponseBinary(Response response) throws RedisException {
-        return handleRedisResponse(GlideString.class, EnumSet.noneOf(ResponseFlags.class), response);
-    }
-
     protected String handleStringOrNullResponse(Response response) throws RedisException {
         return handleRedisResponse(
                 String.class, EnumSet.of(ResponseFlags.IS_NULLABLE, ResponseFlags.ENCODING_UTF8), response);
@@ -948,7 +944,7 @@ public CompletableFuture<String> getrange(@NonNull String key, int start, int en
     public CompletableFuture<GlideString> getrange(@NonNull GlideString key, int start, int end) {
         GlideString[] arguments =
                 new GlideString[] {key, gs(Integer.toString(start)), gs(Integer.toString(end))};
-        return commandManager.submitNewCommand(GetRange, arguments, this::handleStringResponseBinary);
+        return commandManager.submitNewCommand(GetRange, arguments, this::handleGlideStringResponse);
     }
 
     @Override

diff --git a/java/client/src/main/java/glide/api/RedisClient.java b/java/client/src/main/java/glide/api/RedisClient.java
@@ -119,7 +119,7 @@ public CompletableFuture<String> ping(@NonNull String message) {
     @Override
     public CompletableFuture<GlideString> ping(@NonNull GlideString message) {
         return commandManager.submitNewCommand(
-                Ping, new GlideString[] {message}, this::handleStringResponseBinary);
+                Ping, new GlideString[] {message}, this::handleGlideStringResponse);
     }
 
     @Override

diff --git a/java/client/src/main/java/glide/api/RedisClusterClient.java b/java/client/src/main/java/glide/api/RedisClusterClient.java
@@ -1,6 +1,7 @@
 /** Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0 */
 package glide.api;
 
+import static glide.api.BaseClient.OK;
 import static glide.api.commands.ServerManagementCommands.VERSION_REDIS_API;
 import static glide.api.models.GlideString.gs;
 import static glide.api.models.commands.SortBaseOptions.STORE_COMMAND_STRING;
@@ -157,7 +158,7 @@ public CompletableFuture<String> ping(@NonNull String message) {
     @Override
     public CompletableFuture<GlideString> ping(@NonNull GlideString message) {
         return commandManager.submitNewCommand(
-                Ping, new GlideString[] {message}, this::handleStringResponseBinary);
+                Ping, new GlideString[] {message}, this::handleGlideStringResponse);
     }
 
     @Override
@@ -174,7 +175,7 @@ public CompletableFuture<String> ping(@NonNull String message, @NonNull Route ro
     @Override
     public CompletableFuture<GlideString> ping(@NonNull GlideString message, @NonNull Route route) {
         return commandManager.submitNewCommand(
-                Ping, new GlideString[] {message}, route, this::handleStringResponseBinary);
+                Ping, new GlideString[] {message}, route, this::handleGlideStringResponse);
     }
 
     @Override