Skip to content

Commit

Permalink
Remove goimports as a tool dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
aaron-congo committed Feb 22, 2024
1 parent e5ed300 commit 43d9a13
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ jobs:
fail-fast: false
matrix:
go:
# - '1.18'
- '1.18'
- '1.21'
redis:
# - 6.2.14
- 6.2.14
- 7.2.3
os:
- ubuntu-latest
# - macos-latest
- macos-latest

runs-on: ${{ matrix.os }}

Expand Down Expand Up @@ -79,9 +79,6 @@ jobs:
working-directory: ./go
run: make build

- name: Setup upterm session
uses: lhotari/action-upterm@v1

- name: Run linters
working-directory: ./go
run: make lint
Expand Down
4 changes: 0 additions & 4 deletions go/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,13 @@ install-tools-go1.18:
go install github.com/vakenbolt/[email protected]
go install google.golang.org/protobuf/cmd/[email protected]
go install mvdan.cc/[email protected]
go install golang.org/x/tools/cmd/[email protected]
go install github.com/segmentio/[email protected]
go install honnef.co/go/tools/cmd/[email protected]

install-tools:
go install github.com/vakenbolt/[email protected]
go install google.golang.org/protobuf/cmd/[email protected]
go install mvdan.cc/[email protected]
go install golang.org/x/tools/cmd/[email protected]
go install github.com/segmentio/[email protected]
go install honnef.co/go/tools/cmd/[email protected]

Expand Down Expand Up @@ -38,12 +36,10 @@ lint:
staticcheck ./...
if [ "$$(gofumpt -l . | wc -l)" -gt 0 ]; then exit 1; fi
if [ "$$(golines -l --shorten-comments -m 127 . | wc -l)" -gt 0 ]; then exit 1; fi
if [ "$$(goimports -l . | wc -l)" -gt 0 ]; then exit 1; fi

format:
gofumpt -w .
golines -w --shorten-comments -m 127 .
goimports -w .

unit-test-report:
mkdir -p reports
Expand Down

0 comments on commit 43d9a13

Please sign in to comment.