Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use aws sdk auth token gen #5

Merged
merged 2 commits into from
Jan 7, 2025
Merged

use aws sdk auth token gen #5

merged 2 commits into from
Jan 7, 2025

Conversation

vic-tsang
Copy link

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT-0 license.

Thank you for your contribution!

Victor Tsang and others added 2 commits January 6, 2025 14:01
move defer closer to original caller
Copy link
Collaborator

@imforster imforster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our discussion was tested local and github is not setup to obtain aws credentials due to IAM roles and secrets.

@imforster imforster merged commit c16f518 into main Jan 7, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants