Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify namings and minor change #320

Merged
merged 14 commits into from
Apr 23, 2024
Merged

Unify namings and minor change #320

merged 14 commits into from
Apr 23, 2024

Conversation

jay-kim-kor
Copy link
Contributor

@jay-kim-kor jay-kim-kor commented Apr 23, 2024

  • Unify every Orakl services to have prefix orakl-.
  • Changed assign external IP address oforakl-monitor-api method:
    • before: Write loadBalancerIP directly into ./template/service.yaml file.
    • after: Write service.loadBalancerIP in values file.

Please ignore CI failed. I think it's not working properly. Because I passed to lint in my local machine. And also it's can generate(--dry-run).

@jay-kim-kor jay-kim-kor self-assigned this Apr 23, 2024
@jay-kim-kor jay-kim-kor requested a review from a team April 23, 2024 05:07
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nick-bisonai
Copy link
Contributor

lgtm!

@jay-kim-kor jay-kim-kor merged commit 3428902 into main Apr 23, 2024
1 check failed
@jay-kim-kor jay-kim-kor deleted the feat/unify-url-namings branch April 23, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants