Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy baobab-cli-v0.6.1.20240411.1128.5a6190e #288

Merged

Conversation

nick-bisonai
Copy link
Contributor

baobab-cli-v0.6.1.20240411.1128.5a6190e

Update cli settings urls

Description

currently env variables should also be updated from pods
commands such as followed aren't working unless sending host port parameter together
yarn cli listener active

Error: getaddrinfo ENOTFOUND orakl-core-aggregator-listener.orakl.svc.cluster.local

Assuming it should be updated to http://orakl-aggregator-listener.orakl.svc.cluster.local

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package

  • Should publish Docker image

  • PR: 1357

@nick-bisonai nick-bisonai self-assigned this Apr 15, 2024
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nick-bisonai
Copy link
Contributor Author

LGTM!

please approve, you've left only comment
thank you

Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nick-bisonai nick-bisonai merged commit f7f3846 into gcp-baobab-prod Apr 15, 2024
1 check passed
@nick-bisonai nick-bisonai deleted the deploy/baobab-cli-v0.6.1.20240411.1128.5a6190e branch April 15, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants