Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies isolate-test while retaining DBUS support #1531

Closed
wants to merge 1 commit into from

Conversation

xsdg
Copy link
Contributor

@xsdg xsdg commented Oct 27, 2024

Also shows the environment that each isolated test will be run with, to facilitate debugging.

Note that this currently relaxes G_DEBUG="fatal-warnings" to G_DEBUG="fatal-critical" to allow tests to run without triggering SIGTRAP immediately. TBD why this behavior changed with the GTK4 updates.

Sample run output:

 1/55 geeqie:functional / Basic test                                                         OK               0.43s
――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
stdout:
Creating Geeqie dir:/tmp/tmp.KXuWSqblYM/.config/geeqie

Creating Geeqie dir:/tmp/tmp.KXuWSqblYM/.local/share/geeqie/collections

Creating Geeqie dir:/tmp/tmp.KXuWSqblYM/.cache/geeqie/thumbnails

Creating Geeqie dir:/tmp/tmp.KXuWSqblYM/.local/share/geeqie/metadata

Creating Geeqie dir:/tmp/tmp.KXuWSqblYM/.config/geeqie/layouts

Geeqie 2.5 GTK3
stderr:
Variables in isolated environment:
G_DEBUG=fatal-critical
HOME=/tmp/tmp.KXuWSqblYM
XDG_CONFIG_HOME=/tmp/tmp.KXuWSqblYM/.config
XDG_RUNTIME_DIR=/tmp/tmp.KXuWSqblYM/.runtime
DBUS_SESSION_BUS_ADDRESS=unix:path=/tmp/dbus-fDzY1Y2eq3,guid=943eba8e6f3d1b6e01e8bfba671dabbb

MESA: error: ZINK: vkCreateInstance failed (VK_ERROR_INCOMPATIBLE_DRIVER)
glx: failed to create drisw screen
failed to load driver: zink

(geeqie:831550): dbind-WARNING **: 02:55:56.126: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

@caclark
Copy link
Collaborator

caclark commented Oct 29, 2024

@xsdg

Your pull request resulted in an error - it was not related to your patch and it is now fixed.

However I get errors when running tests locally. A shortcut to see the errors is:
./scripts/isolate-test.sh xvfb-run --auto-servernum <somewhere>/build/src/geeqie --version

The errors I see are:
1531-1.txt.gz

If I exec dbus-run-session I do not get any erors.

Do you see this problem on your system?

@xsdg
Copy link
Contributor Author

xsdg commented Oct 29, 2024

Colin: that's not something I've seen, but it could easily be a versioning or installed-package issue.

(xdg-desktop-portal-gtk:185593): Gtk-WARNING **: 13:36:08.768: cannot open display:

Seems particularly interesting. I'll poke around and see if I can repro (either locally or in github)

@xsdg
Copy link
Contributor Author

xsdg commented Oct 29, 2024

Filed #1532 to track this. Current hypothesis is a race condition during cleanup, but we'll see.

@xsdg
Copy link
Contributor Author

xsdg commented Oct 29, 2024

This is already merged, and the issue Colin found is tracked in #1532 and fixed by #1533

@xsdg xsdg closed this Oct 29, 2024
@xsdg xsdg deleted the dbus_isolate branch October 29, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants