Moves FileList functions to their own file/class (Phases 3/4 from #1369) #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also creates a protected FileData API, which includes methods that originally existed as static functions within `filedata/filedata.cc`. Those protected methods are now accessible to FileData and its child classes, without being made accessible to code outside of the FileData class.
|
@qarkai definitely going to want your thoughts on this |
qarkai
reviewed
Jun 5, 2024
That said, this renames `filelist_free` to `free_list` and `filelist_read*` to `read_list*` in order to avoid confusion with the `free` and `read` function names that are super common in C.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also creates a protected FileData API, which includes methods that originally existed as static functions within
filedata/filedata.cc. Those protected methods are now accessible to FileData and its child classes, without being made accessible to code outside of the FileData class.This is part of the #1369 refactor (phases 3 and 4)