fix: drop unsupported non-whitespace characters for real when calling… #7484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… anthropic with stop sequences
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -257,17 +258,13 @@ def _map_stop_sequences( | |||
| ) -> Optional[List[str]]: | |||
| new_stop: Optional[List[str]] = None | |||
| if isinstance(stop, str): | |||
| if ( | |||
There was a problem hiding this comment.
can you add a unit test for this @WolframRavenwolf - https://github.com/BerriAI/litellm/blob/main/tests/llm_translation/test_anthropic_completion.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… anthropic with stop sequences
Title
Anthropic doesn't allow whitespace characters as stop-sequences. This fix expands upon a previous implementation and fully fixes the issue.
Relevant issues
Expands upon #3436 and fixes #3286 for real.
Type
🐛 Bug Fix
Changes
The original fix only applied to a single newline, which didn't help when other or multiple kinds of whitespace were used. This new implementation of the old fix now covers any and all types and numbers of whitespace, solving the issue completely.