Battlecruiser Gungnir #2737
Open
Battlecruiser Gungnir #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed it during the initial backup-copy
It probably works
Shuttlecode might actually fucking work
Final Before PR
I found 2 braincells to try to fix
Dear gods, someone taught me to do a thing
I would have had muni complaining about a breach at sub-20 minutes.
Makes it votable so a certain host can select and break it. Yes, I submitted a commit for a one line change. No, I don't know what I'm doing.
i dont like red on my PR it makes it harder to poke the cube
Fixed: muni belts, added AI and supply viewscreens, doubled atmos vents to muni, tripled the initial capacity of the Plasma, N2 and O2 tanks, fixed the existence of prototype cannisters and last but not least, take goddamned 52 on making the supply shuttle work.
This marks the addition of the new FTL drive... And the addition of the PDSR to the Gungnir, along with a few other fixes.
Added Ships description in the JSON, Added Armor FWD and AFT, Replaced gungnir shuttle with one from the tycoon. Minor fixes.
This wouldn't be a problem if I didn't remember that I intended to change things at odd moments.
Miscellaneous other crap. I also just now figured out that you can pin attributes to make it easier to track.
Holy shit, after almost a year, only 15 total straight mapping errors
SerynEngi
requested review from
covertcorvid,
Bokkiewokkie and
a team
as code owners
SerynEngi
force-pushed
the
GungnirBattlecruiser
branch
from
3920db0 to
6f17a3b
Compare
Now in compliance with the mapping standard I added today.
|
What exactly is going on in the |
ill clean that up here in a bit, i accidentally left in the testing configuration changes, please disregard, as those changes were based on a config file that is now highly out of date. This has mostly been PRed so that the map can be reviewed more easily and potentially added to the lineup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This will add the large scale, gun-focused cruiser Gungnir to our rotation.
Why It's Good For The Game
Created to be a gun focused counterpart to the Tycoon (when I finish reworking it back into a pure/nearly pure carrier) this ship has some fighters, but is primarily focused on guns, with an expansive munitions bay.
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
add: NSV Gungnir
add: Armor Destruction Grenade preset
/:cl: