Secure Beanstalk Invariants #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funderbrker
force-pushed
the
secure-beanstalk-invariants
branch
from
95752fd to
9b539f6
Compare
|
Should depot facet have the noSupplyChange invariant? Currently yes bc its use is intended to be moving control from from Beanstalk to external. Sequences of Beanstalk actions should be achieved using external pipeline or Farm/AdvancedFarm. |
|
omw to implement some sort of tests... |
Brean0
reviewed
Apr 20, 2024
funderbrker
force-pushed
the
secure-beanstalk-invariants
branch
from
e5b4fdf to
385b9c9
Compare
funderbrker
force-pushed
the
secure-beanstalk-invariants
branch
from
385b9c9 to
a38a8e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements 3 invariants
fundsSafu
Ensures that Beanstalk contract holds enough assets to pay all users all of their expected existing funds.
This invariant applies to every writing function in Beanstalk. There are a few exceptions in the Diamond system.
noNetFlow
Verifies that no assets have entered or exited Beanstalk during the function execution and that Stalk has not decrease (which should never happen without some underlying asset changes). This applies to the majority of writing functions, excepting functions that are explicitly converting or transferring assets into or out of Beanstalk on behalf of a user. Also excepting diamond features.
noSupplyChange
Verifies that the supply of Bean has not changed during execution. ie there has been no minting or burning. This applies to vast majority of writing functions, excepting the functions that explicitly mint or burn (like sunrise or sow). Also excludes diamond features.
The set of assets checked in these invariants is the list of Silo assets at the beginning of the call. Currently, this includes Beans and LP tokens. The value underlying the LP cannot and should not be verified inside of Beanstalk. The list of covered tokens can be expanded to a known set, but should not be an infinitely scaling set of n possible internal ERC20s.