Basin UI (3) - Yield info + misc fixes #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xalecks
suggested changes
Dec 11, 2023
0xalecks
suggested changes
Dec 13, 2023
| const getSeedsWithWell = useCallback( | ||
| (well: Well | undefined) => { | ||
| if (!well?.lpToken) return undefined; | ||
| return sdk.tokens.findByAddress(well.lpToken.address)?.getSeeds(); |
There was a problem hiding this comment.
In order for .getSeeds() to work, you MUST call sdk.refresh()
Note, this requires BIP39, which hasn't been deployed yet so this means we cannot merge this PR until after.
Happy to chat about this if you have questions. You don't need to set the seed for each token like I did in the UI PR below the line commented, that was only to update the UI's tokens... the SDK will update its tokens on refresh().
…eld-and-housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In This PR:
To deploy an empty well for testing, you can run npx ts-node projects/examples/src/wells/deployNewWell.ts from the project root folder