Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/76888 #162

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Issue/76888 #162

merged 4 commits into from
Nov 29, 2024

Conversation

tyffany-robbes
Copy link
Contributor

76888 - fix errors 10 & 11 - ensures variables are not empty arrays before use

@tyffany-robbes tyffany-robbes self-assigned this Nov 22, 2024
@asadowski10 asadowski10 requested a review from petitphp November 22, 2024 09:23
petitphp
petitphp requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@petitphp petitphp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour la PR. J'ai laissé quelques commentaires pour corriger un bug et améliorer le sens du code dans une condition.

Il faudra penser à appliquer les coding standard sur le code PHP aussi.

classes/addons/gutenberg.php Outdated Show resolved Hide resolved
classes/addons/gutenberg.php Outdated Show resolved Hide resolved
classes/addons/yoast-seo.php Outdated Show resolved Hide resolved
@tyffany-robbes
Copy link
Contributor Author

Merci @petitphp pour tes retours !
J'ai fait les corrections. Tu saurais me dire pourquoi les checks sont notés sur failed ? Des problèmes de version visiblement. Y'a un truc que j'ai pas fait correctement ?

@tyffany-robbes
Copy link
Contributor Author

@petitphp le point qui manquait a été ajouté :) désolée pour l'oubli

petitphp
petitphp approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@petitphp petitphp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bon pour moi.

@tyffany-robbes tyffany-robbes merged commit 10d84ec into master Nov 29, 2024
0 of 3 checks passed
@herewithme herewithme deleted the issue/76888 branch January 21, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petitphp petitphp petitphp approved these changes

@asadowski10 asadowski10 Awaiting requested review from asadowski10

Assignees

@tyffany-robbes tyffany-robbes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyffany-robbes @petitphp