Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Implement system exit code on error #77

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Implement system exit code on error #77

merged 1 commit into from
Aug 14, 2022

Conversation

niklasbogensperger
Copy link

@niklasbogensperger niklasbogensperger commented Jul 7, 2022

Would solve my own open issue.
Closes #76
There is potential to implement more granular exit codes in the future.

Would solve my own open issue #76.
There is potential to implement more granular exit codes in the future.
@niklasbogensperger
Copy link
Author

niklasbogensperger commented Jul 7, 2022

Sample log output (see my issue for comparison):

❯ ./zoomdl -u https://www.zoom.us/rec/play/404 -v 0
Using standard Windows UA
Changing page to https://www.zoom.us/rec/play/404
Advanced meta failed
Unable to extract chatList from page
Unable to extract transcriptList from page
Metas are {'cookie_currency': 'EUR', 'currency_symbol': '€', '__platformCheck': '', 'detect': 'https://st2.zoom.us/cdn-detect.png', 'chatList': [], 'transcriptList': []}
No video URL in meta, going bruteforce
[ERROR] Video not found in page. Is it login-protected? 
Try to refresh the webpage, and export cookies again
Unable to find metadata, aborting.

❯ echo $?
1

I also confirmed it still works as expected with a valid zoom recording link. It just returns exit status 0 as before and as intended.

@niklasbogensperger
Copy link
Author

I just realized that there are indeed some sys.exit() statements already implemented (also in another pull request, #75; ex. line), but not all errors are actually covered as evidenced by the log in my issue.

I don't know which solution you prefer (a sys.exit() after every individual error vs. a sys.exit(exit_code) at the end of the script) but I think it would be good if it is implemented consistently.

@Battleman
Copy link
Owner

I see the problem. I'll merge that one into Beta and see what looks best. Thanks for the contribution.

@Battleman Battleman changed the base branch from master to Beta August 14, 2022 15:42
@Battleman Battleman merged commit bf5aaed into Battleman:Beta Aug 14, 2022
@niklasbogensperger
Copy link
Author

I see the problem. I'll merge that one into Beta and see what looks best. Thanks for the contribution.

Thanks! Let me know if I can help at all with implementing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement exit statuses
2 participants