Culture insensitive default config #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config on class did not match what ended up in the default config file
When no config is found, a new one will be made with the current locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When I try to run BasisNetworkConsole it crashes on startup and complains that a float is in the wrong format.
The problem is that
float.Parseis culture sensitive. The default config writes a float as0.005with a dot. My default locale reads floats with commas and throws a format exception. It needs the float to be0,005to parse.Fix
Use a locale independent xml reader/writer. When I use the
XmlSerializerthe float is written as0.005and is read without issue.I also removed the triplicate of defaults. I used the values that got written to file before I started changing things as the default values.