-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto release new minor versions #33
Conversation
Major version bump should be done manually |
👍 great! hey, the trigger is? i mean when this "auto" release tag will be deploy? witch action does the triggering ? |
i mean you put
this has a problem, on any commit+push we will have a release no matter is there is a test failing or not! so your proposal maybe is : have a stable branch for release and a develop branch ? |
I agree with @mckaygerhard ... "Automated" release naming would be done even in case there is a test failing, or anything else failing, that is, e.g., I don't want a new release (at least, I don't want it yet ). |
trigger could be whatever you want, could run only after success test.. (change needed) Or bind to tag (major minor patch no-release) automated releases could be named like you want (marked as you want pre-release, latest etc)
That is good practice |
So, if I've got it properly, when I type in my terminal: then Github would create, say, the version 12.0.7 of EBG, automatically? Am I correct ? |
12.1.0 in this PR could be changed don't know what patch do differently |
Or you can use bash in github action for anything you want.. |
So, my friend... We would have only 9 possible changes before major version change... This project is not so "live & working", anyway I see this as a limitation... @mckaygerhard what do you think about? |
12.99.0 |
its scripting, anything isn't set in stones (i hope) only boundary is your imagination |
Oh ! right ! :P
Namely, you are saying that, e.g. for a potential 12.0.7, I still could do pushing by a new tag from my terminal ?
I absolutely agree ! you know... I'm just trying to realize because I'm not at all Github expert: only for this reason! |
you are not! we are working with computers which can oprate with anything we will give them. (not only 1-9)
|
I'm seriously considering it... With this auto-versioning... Is still possible changing version manually by tag, from terminal? |
sure or can be triggered only manually. so one click for you with version change (which one you choose) with complet changelog in few seconds or better don't ask what you can, tell what you want...
anything is possible, you just need figured out how could be changed...
Me to, just bit more experienced, since working against actions often 😃 |
I hope my question will not mind you... (really): If I possibly would change my mind about auto-versioning, how could I come back? |
that minor major patch no0release could be also override with appropriate label in PR name look on actions READMEs in repo itself...
just delete yml file or change trigger in action to worflow_dispatch only (manual trigger) |
don't ask what you can, tell what you want... |
And where will be that file? In same location of LICENSE file ? |
look at 1 changed file in this PR under .github/workflows/any-name-you-want.yml PS: added some comments inside file to better understand.. |
Thank you very much, now is more understandable! :P Still I didn't understand where will go that .yml file in EBG tarball... |
nowhere. its hidden file just for github. it's why is under .github/ (like github dotfile) |
@zen0bit change the script to use tags.. that solve the problem for @vaisarger so he can decide when release using tag marks |
I don't have that directory... where is ? (sorry ) |
ls -la will show you.. any dir with dot as prefix will be hidden in linux also if you dont have the changes from him will not have such change and directory! dont worry such directory by the way i posted a message before for him! maybe will help to you |
Or you can create release[anyname] branch and if you push changes there, that will trigger new release.. |
sure, create only if needed |
I added a lot comments etc. to better see how github workflow works.. |
#paths-ignore: [ '**/README.md' ] | ||
|
||
# Triggers the workflow if matching tag is created | ||
tags: [ 'v*.*' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now we must explain to @vaisarger that will only trigerr when make a custom tag..
@vaisarger it means no release will be publised .. and only if you tagged will be publised
Just define what exactly wanna achieve and your current workflow/staff used |
yes looks good to me! |
Sorry guys, we Open Source developers have a (tough) life also... :P
Thank you for your patience... |
yes
On line 21 tag is set to You can look at my repo where I am trying that. (WebUI) In actions and releases you see.. Used this command to add and push tag must match next elease number, because action will create number depending on last number not that you provided..
yes Here is full yaml file from author:
And repo for README etc... |
Ok. Now... I usually use these commands to add and push: ... After this PR, what will the list of commands look like? ??? |
umm now makes sense to me your questions. . @zen0bit needs a letter like "v" to discern if the tag is to make a release, but you do not use letters and use only numbers.. umm i have some ideas to improve your PR @zen0bit but i will check it in deep only this weekend.. |
@vaisarger i tested and if you want to be release only on tags we can change the behaviour but liked the idea! |
look at second PR and again at my repo to what happened... |
we can close this I think... |
seems you works so much @zen0bit yeah. close this and let @vaisarger check #36 that it follows the schema number as X.Y.Z for tags releases |
Completed in #36 |
No description provided.