Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom MultiImageStreamCompleter with flutter/foundation/MultiFrameImageStreamCompleter #949

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Replace custom MultiImageStreamCompleter with flutter/foundation/MultiFrameImageStreamCompleter #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cached_network_image/lib/cached_network_image.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@ export 'package:flutter_cache_manager/flutter_cache_manager.dart'

export 'src/cached_image_widget.dart';
export 'src/image_provider/cached_network_image_provider.dart';
export 'src/image_provider/multi_image_stream_completer.dart';
1 change: 0 additions & 1 deletion cached_network_image/lib/src/image_provider/_image_loader.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ class ImageLoader implements platform.ImageLoader {
headers: headers,
key: cacheKey,
);

await for (final result in stream) {
if (result is DownloadProgress) {
chunkEvents.add(
Expand Down
9 changes: 4 additions & 5 deletions cached_network_image/lib/src/image_provider/cached_network_image_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import 'dart:async' show Future, StreamController;
import 'dart:ui' as ui show Codec;

import 'package:cached_network_image/src/image_provider/multi_image_stream_completer.dart';
import 'package:cached_network_image_platform_interface/cached_network_image_platform_interface.dart'
show ErrorListener, ImageRenderMethodForWeb;
import 'package:cached_network_image_platform_interface/cached_network_image_platform_interface.dart'
Expand Down Expand Up @@ -77,8 +76,8 @@ class CachedNetworkImageProvider
DecoderBufferCallback decode,
) {
final chunkEvents = StreamController<ImageChunkEvent>();
final imageStreamCompleter = MultiImageStreamCompleter(
codec: _loadBufferAsync(key, chunkEvents, decode),
final imageStreamCompleter = MultiFrameImageStreamCompleter(
codec: _loadBufferAsync(key, chunkEvents, decode).first,
chunkEvents: chunkEvents.stream,
scale: key.scale,
informationCollector: () => <DiagnosticsNode>[
Expand Down Expand Up @@ -128,8 +127,8 @@ class CachedNetworkImageProvider
ImageDecoderCallback decode,
) {
final chunkEvents = StreamController<ImageChunkEvent>();
final imageStreamCompleter = MultiImageStreamCompleter(
codec: _loadImageAsync(key, chunkEvents, decode),
final imageStreamCompleter = MultiFrameImageStreamCompleter(
codec: _loadImageAsync(key, chunkEvents, decode).first,
chunkEvents: chunkEvents.stream,
scale: key.scale,
informationCollector: () => <DiagnosticsNode>[
Expand Down
238 changes: 0 additions & 238 deletions cached_network_image/lib/src/image_provider/multi_image_stream_completer.dart
View file
Open in desktop

This file was deleted.

Loading
Loading