Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge #4

Merged
merged 43 commits into from
Aug 28, 2024
Merged

merge #4

merged 43 commits into from
Aug 28, 2024

Conversation

BabyElias
Copy link
Owner

Description

Issue addressed

Addresses #PR# HERE

Before/after screenshots

Changelog

  • [#PR no]
    • Description: Summary of change(s)
    • Products impact: Choose from - none (for internal updates) / bugfix / new API / updated API / removed API. If it's 'none', use "-" for all items below to indicate they are not relevant.
    • Addresses: Link(s) to GH issue(s) addressed. Include KDS links as well as links to related issues in a consumer product repository too.
    • Components: Affected public KDS component. Do not include internal sub-components or documentation components.
    • Breaking: Will this change break something in a consumer? Choose from: yes / no
    • Impacts a11y: Does this change improve a11y or adds new features that can be used to improve it? Choose from: yes / no
    • Guidance: Why and how to introduce this update to a consumer? Required for breaking changes, appreciated for changes with a11y impact, and welcomed for non-breaking changes when relevant.

[#PR no]: PR link

Steps to test

  1. Step 1
  2. Step 2
  3. ...

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

MisRob and others added 30 commits September 28, 2023 20:29
- This component enables focus movenment on radio buttons with arrow keys on firefox
- Add KRadioButton method description
- Add KRadioButtonGroup slot and props description
- This component enables focus movenment on radio buttons with arrow keys on firefox
- Add KRadioButton method description
- Add KRadioButtonGroup slot and props description
- Used ._componentTag instead of ._name
- Changed onkeydown with onkeyup listener
- Use recursion to query all KRadioButton
- In test avoid internval variable use
MisRob and others added 13 commits August 26, 2024 11:04
…tonGroup-Component

Made a new KRadioButtonGroup component to fix Firefox radio button movement with arrow keys issue
Co-authored-by: Michaela Robosova <[email protected]>
Co-authored-by: Michaela Robosova <[email protected]>
Co-authored-by: Michaela Robosova <[email protected]>
Co-authored-by: Michaela Robosova <[email protected]>
Co-authored-by: Michaela Robosova <[email protected]>
…esolve

Removed the border-radius on align left
@BabyElias BabyElias merged commit da2ec92 into gsoc-table-develop Aug 28, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants