Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prediction #69

Open
wants to merge 10 commits into
base: prediction
Choose a base branch
from
Open

Prediction #69

wants to merge 10 commits into from

Conversation

johan-gson
Copy link
Contributor

These are the most recent changes to bustools from dePcr etc, just merge it

Copy link
Contributor

@yfarjoun yfarjoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just adding two comments pointing out where the code should be amended to error out on unexpected arguments.

break;
case 'e':
opt.count_ecs = optarg;
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a case '?' like in #95 to spot an unexpected argument

case 'c':
opt.cluster_input_file = optarg;
break;
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a case '?' like in #95 to spot an unexpected argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants