Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX 개선]: 사장님 가게 등록 UX 개선 #387

Merged
merged 12 commits into from
Feb 12, 2025

Conversation

daepan
Copy link
Contributor

@daepan daepan commented Jan 16, 2025

  • Close #ISSUE_NUMBER

What is this PR? 🔍

  • 기능 : 사장님 모바일 뷰 UX 개선
  • issue : #

Changes 📝

  • 전체적인 UX 위치를 개선하였고, 하단 버튼을 개선하였습니다.

ScreenShot 📷

image
2025-01-16.5.03.25.mov

Test CheckList ✅

  • test 1
  • test 2
  • test 3

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run yarn lint

Copy link
Contributor

@hyejun0228 hyejun0228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! Close #ISSUE_NUMBER 만 수정해주세요!

hoooooony and others added 7 commits January 17, 2025 23:40
* fix : main_category_id가 처음 회원 가입시에는 undefined이기 때문에 optional로 변경

* fix: 사장님 가게 타입에 main_category_id 추가

* fix: 가게 정보 수정 시 기본 메인 카테고리 값 추가

---------

Co-authored-by: (hoooooony) <([email protected])>
Co-authored-by: chaeseungyun <[email protected]>
@hoooooony hoooooony merged commit 7a2abec into develop Feb 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants