Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt BCCDC-PHL/FluViewer #8

Merged
merged 13 commits into from
Jul 3, 2024
Merged

Adopt BCCDC-PHL/FluViewer #8

merged 13 commits into from
Jul 3, 2024

Conversation

dfornika
Copy link
Member

Fixes #7

@jpalmer37
Copy link
Collaborator

Nearly done testing. The fluviewer Nextflow process required some changes.

@jpalmer37
Copy link
Collaborator

Finished pipeline testing. Looks good to me. Would welcome a double check if desired.

@dfornika dfornika marked this pull request as ready for review July 3, 2024 16:44
@dfornika dfornika requested a review from jpalmer37 July 3, 2024 16:45
jpalmer37
jpalmer37 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@jpalmer37 jpalmer37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpalmer37 jpalmer37 merged commit 55db1f8 into main Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpalmer37 jpalmer37 jpalmer37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adopting BCCDC-PHL/FluViewer
2 participants
@dfornika @jpalmer37