Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on testing pipeline #5

Merged
merged 24 commits into from
Jun 7, 2024
Merged

Work on testing pipeline #5

merged 24 commits into from
Jun 7, 2024

Conversation

dfornika
Copy link
Member

@dfornika dfornika commented Jun 5, 2024

Fixes #1
Fixes #6

As part of the GitHub Actions-based testing workflow involves checking the provenance outputs against our pipeline-provenance-schema this PR also includes updates to the provenance file format.

Superficial modifications have been made to the pipeline's conda envs. Their contents should remain the same, but their names and hashes have been updated. This will cause new conda envs to be created when this version of the pipeline is run for the first time.

@dfornika dfornika marked this pull request as draft June 5, 2024 18:57
@dfornika dfornika marked this pull request as ready for review June 6, 2024 00:54
@dfornika
Copy link
Member Author

dfornika commented Jun 6, 2024

I think I've pushed this along as far as I can in this PR. The test pipeline is passing, but fluviewer appears to be failing in the test environment. I'm having trouble collecting an error message in the artifacts generated by the testing pipeline.

If possible I'd like to merge this as-is and follow up with smaller PR(s) to fix the remaining issue.

@dfornika dfornika requested a review from JamesZlosnik June 6, 2024 00:58
@JamesZlosnik
Copy link
Member

Thank you Dan!!

@jpalmer37 would you mind running this on a test run? I'll do the same and report back here.

James

@JamesZlosnik
Copy link
Member

tested on a test dataset and worked great - we can merge this now.

Copy link
Member

@JamesZlosnik JamesZlosnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on a test data set, worked well.

@dfornika dfornika merged commit d3e1bfc into main Jun 7, 2024
1 check passed
@jpalmer37
Copy link
Collaborator

My apologies, didn't catch you in time. I was caught up debugging a very odd state that I've run into before where all outputs are accounted for but for some reason all the provenance processes fail to register and run.

Aside from that, the pipeline seems to be working fine on my side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove --versioned_outdir param Add a GitHub Actions-based testing workflow
3 participants