-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work on testing pipeline #5
Conversation
I think I've pushed this along as far as I can in this PR. The test pipeline is passing, but fluviewer appears to be failing in the test environment. I'm having trouble collecting an error message in the artifacts generated by the testing pipeline. If possible I'd like to merge this as-is and follow up with smaller PR(s) to fix the remaining issue. |
Thank you Dan!! @jpalmer37 would you mind running this on a test run? I'll do the same and report back here. James |
tested on a test dataset and worked great - we can merge this now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on a test data set, worked well.
My apologies, didn't catch you in time. I was caught up debugging a very odd state that I've run into before where all outputs are accounted for but for some reason all the provenance processes fail to register and run. Aside from that, the pipeline seems to be working fine on my side! |
Fixes #1
Fixes #6
As part of the GitHub Actions-based testing workflow involves checking the provenance outputs against our pipeline-provenance-schema this PR also includes updates to the provenance file format.
Superficial modifications have been made to the pipeline's conda envs. Their contents should remain the same, but their names and hashes have been updated. This will cause new conda envs to be created when this version of the pipeline is run for the first time.