Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed outdir schema for all processes #11

Merged
merged 3 commits into from
Jul 4, 2024
Merged

changed outdir schema for all processes #11

merged 3 commits into from
Jul 4, 2024

Conversation

jpalmer37
Copy link
Collaborator

@jpalmer37 jpalmer37 commented Jul 3, 2024 •
edited
Loading

Fixes: #4

@jpalmer37 jpalmer37 requested a review from dfornika July 3, 2024 20:15
dfornika
dfornika requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@dfornika dfornika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a couple small changes aimed at bringing this pipeline more in-line with how our other pipelines behave.

modules/provenance.nf Outdated Show resolved Hide resolved
nextflow.config Show resolved Hide resolved
@dfornika dfornika self-requested a review July 4, 2024 16:54
dfornika
dfornika approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@dfornika dfornika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks great. Thanks!

@dfornika dfornika merged commit 4437565 into main Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfornika dfornika dfornika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move responsibility for higher-level output directory structure outside pipeline
2 participants
@jpalmer37 @dfornika