Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small update to .prettierrc file & version bump #1225

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Small update to .prettierrc file & version bump #1225

merged 1 commit into from
Feb 11, 2025
+10 −6

Conversation

tejhan
Copy link
Collaborator

@tejhan tejhan commented Feb 10, 2025

Changes

This PR has a slight modification to the .prettierrc file, and a version bump for prettier.

Related Issue: #1162

@tejhan tejhan added the dependencies Pull requests that update a dependency file label Feb 10, 2025
@tejhan tejhan self-assigned this Feb 10, 2025
@Tatsinnit Tatsinnit linked an issue Feb 10, 2025 that may be closed by this pull request
Add Code Formatter Check!! Thoughts? #1162
Closed
Tatsinnit
Tatsinnit approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Please make sure you have run this locally with npc prettier --write . and hope no files come in to checkin, reason to check is to make sure it won't have many files for any individual after this. Thank you for this.

@tejhan
Copy link
Collaborator Author

tejhan commented Feb 10, 2025

💡 Please make sure you have run this locally with npc prettier --write . and hope no files come in to checkin, reason to check is to make sure it won't have many files for any individual after this. Thank you for this.

Yes, I verified with --write & --check beforehand, everything passed the checks well 👍

@Tatsinnit Tatsinnit merged commit 97a1ea7 into Azure:main Feb 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tatsinnit Tatsinnit Tatsinnit approved these changes

@ReinierCC ReinierCC ReinierCC approved these changes

@qpetraroia qpetraroia Awaiting requested review from qpetraroia

@hsubramanianaks hsubramanianaks Awaiting requested review from hsubramanianaks

Assignees

@tejhan tejhan

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Code Formatter Check!! Thoughts?
3 participants
@tejhan @Tatsinnit @ReinierCC