-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Fleet: panel implementation #1161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setup of everything LGTM !👍, would say some descriptive comments for some functions could help (Like for the validation criteria being used). I'm assuming the ProgressEventTypes are placeholders for now & could be modified in further PR's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐲 Thank you for this PR—this second part of the web view looks good to me! While it’s not yet connected, it’s clear that it’s heading in the right direction, and the U/X folks seem happy with it as well.
We’re now entering a crucial stage beyond this point, where connecting everything together will become key. I’d strongly encourage you to engage with Tejhan and Reinier pro-actively with the next PR, as it will likely be even more critical in tying everything together and ensuring success.
Once again, thank you for your efforts on this PR—it’s an important step forward. Feel free to reach out if there’s anything I can help with, or if more collaboration is needed as we move toward the next phase!
Humble thanks to everyone above for valuable comments.
- Once you cater left over comments, we can plan to
squash, merge
this mid-day today. 🤞 thanks.
Looks good! Solid foundation so far. As you start connecting things the next tricky part will be setting up the "state.ts" file which can be thought as the message/event handling on the webview side. I'd recommend you try to load a simple "Hello World" before tackling the full fleet webview. Feel free to reach out with any questions! |
Thank you all for your valuable comments!! I have carefully reviewed them and addressed all the issues in the latest commit :) |
Description
This pull request introduces the basic panel implementation and required webview definitions for creating fleets in the VSCode extension.
Key Changes
Added Fleet Management Capabilities:
ContainerServiceFleetClient
to manage AKS fleets.getAksFleetClient
function inarm.ts
to create a fleet client.CreateFleetPanel
andCreateFleetDataProvider
classes inCreateFleetPanel.ts
for handling fleet creation UI and logic.New Webview Definitions:
createFleet.ts
underwebviewDefinitions
to define interfaces and message types related to fleet creation.webviewTypes.ts
to includeCreateFleetDefinition
.UI Enhancements:
createFleet
inmain.tsx
andmanualTest/main.tsx
to ensure compilation and future implementation. The code inmain.tsx
is hardcoded to satisfy dependencies for the project to compile.Changes
src/commands/utils/arm.ts
: AddedContainerServiceFleetClient
andgetAksFleetClient
.src/panels/CreateFleetPanel.ts
: Created new panel and data provider for fleet creation.src/webview-contract/webviewDefinitions/createFleet.ts
: Defined types for fleet creation webview.src/webview-contract/webviewTypes.ts
: AddedCreateFleetDefinition
.webview-ui/src/main.tsx
: Added placeholder for fleet creation with hardcoded code to satisfy dependencies.webview-ui/src/manualTest/main.tsx
: Added placeholder for fleet creation test scenarios with hardcoded code to satisfy dependencies.Testing
Notes
createFleet
is not yet visible to users to avoid incomplete experience.