Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: naming convention for bastion, route table and route outputs and template formatting #141

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

johnmckenna
Copy link

@johnmckenna johnmckenna commented Sep 3, 2024

As per: https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-abbreviations

Bastion is bas
Route Table is rt
Route is udr

tflint was complaining as well when running make so I have added a line to the template as well to fix this, this was the error:

1 issue(s) found:

Warning: terraform "required_version" attribute is required (terraform_required_version)

  on main.tf line 1:
   1: terraform {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.9.1/docs/rules/terraform_required_version.md

make: *** [Makefile:28: validate] Error 2``

Fix template formatting as well so it matches terraform fmt by removing spaces

Fixes #142

@johnmckenna johnmckenna force-pushed the fix-naming-convention branch from 92d139e to 02d35bc Compare September 4, 2024 01:31
@johnmckenna johnmckenna changed the title Fix naming convention for bastion, route table and route outputs fix: naming convention for bastion, route table and route outputs Sep 4, 2024
@johnmckenna johnmckenna force-pushed the fix-naming-convention branch from 02d35bc to 1810067 Compare September 4, 2024 01:50
@johnmckenna johnmckenna changed the title fix: naming convention for bastion, route table and route outputs fix: naming convention for bastion, route table and route outputs and template formatting Sep 4, 2024
Copy link

@kstergiopoulos kstergiopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bastion, Route Table and Route do not match documentation
2 participants