Fix ServiceBus Namespace Slug

[GirishMaddineni]

This is the PR for fixing ServiceBus Namespace slug coming from naming module, when using module.naming.servicebus_namespace.name it is throwing an error stating,

Error: "name" cannot end with a hyphen, -sb, or -mgmt │
│ with module.service_bus.azurerm_servicebus_namespace.this,
│ on .terraform/modules/service_bus/main.tf line 3, in resource "azurerm_servicebus_namespace" "this":
│ 3: name = var.name

current Behaviour:
-sb

Expected Behaviour to resolve issue
-sbus

Reference documentation:
https://learn.microsoft.com/en-us/azure/service-bus-messaging/service-bus-quickstart-topics-subscriptions-portal

[GirishMaddineni]

@microsoft-github-policy-service agree

[GirishMaddineni]

@Nepomuceno @shanselman @alloy, can I please get a review on this Issue/PR. it's a blocker for our current work.

[Nepomuceno]

HI @Girish-Maddineni thx for your contribution.

This is breaking change so we unfortunatly cannot approve this change anyone that has deployed a service bus namespace using this module would have it to fail.

you can add a suffix to it so it would not have -sb in the end. I suggest creating a new call to the naming module if you want the suffix to apply just to this.

Also just for the future there is a need to generate the files after you change the definition you can so that by running
make all

[GirishMaddineni]

Thank you @Nepomuceno. I ran the Make all command and Updated PR with latest changes from it. I will make a note to run it in the future.

[davenicoll]

This is breaking change so we unfortunatly cannot approve this change anyone that has deployed a service bus namespace using this module would have it to fail.

you can add a suffix to it so it would not have -sb in the end. I suggest creating a new call to the naming module if you want the suffix to apply just to this.

@Nepomuceno is it a breaking change, if with the currently implemented slug, servicebus namespace can not be deployed? surely everyone has had to workaround this?

can you advise what the next steps are for this PR please? thanks

[Nepomuceno]

@davenicoll This is a breaking change because if someone created a service bus and they are using suffix this would work if we do change this it would recreate their resources.

[jamengual]

Every single change is a breaking change in this module. (based on your comments on other PRs)
Why can't you guys create a major release to support YOUR OWN resource naming standards?
People should tag the version on the module instantiation, so this change should not be considered a breaking change.
Since the module's core goal is to support compatibility with the naming standards of Azure resources, I do not understand why these changes are so difficult to merge.