Remove dashes from Front Door Firewall Policy #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
HI @JeepLavoie thx for your contribution. This is breaking change so we unfortunatly cannot approve this change anyone that has deployed Front door firewall policy using this module would have it to be destroyed and crecreated do you think this could cause dataloss? |
|
Hi @Nepomuceno, Since the Azure FrontDoor WAF don't allow dash in their name this is not a breaking change. This is a screen capture while creating a new WAF from the Portal
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dashes from Front Door Firewall policy since it's not supported by the resources.
This will fix this issue : #87