[FabricClient] Support 'register service notification filter' api #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrahman
reviewed
Aug 13, 2024
jrahman
reviewed
Aug 13, 2024
jrahman
approved these changes
Aug 13, 2024
rsajwani
reviewed
Aug 13, 2024
rsajwani
approved these changes
Aug 13, 2024
youyuanwu
deleted the
users/youyuanwu/support-register-service-notification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial impl for #57
FabricClient can register the service notification filter and unregister it.
See dotnet documentation
The registration mechanism is used inside the dotnet implementation of servicepartitionresolver
The registered service to get notification will no longer need to pass the previous endpoint resolve result to force a refresh. This is tested in the stateful example app. But the notification seems to be not very fast (lag of a couple of seconds). But this notification utilizes FabricClient cache, and reduces the cluster api load.
I will compare with direct resolution next.