Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wait_for_catch_up_quorum documentation #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update wait_for_catch_up_quorum documentation #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/libs/core/src/runtime/stateful.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,11 @@ pub trait LocalPrimaryReplicator: Replicator {
/// For swap primary case, double catchup feature is enabled by default.
/// SF can first call this api before initiating write status revokation. SF then revoke write status,
/// and call this again. This allows replicator to catch up with write status granted to make necessary writes for
/// catch up. There is a chance that replicator takes forever to complete this api with ReplicaSetQuarumMode::All
/// catch up. There is a chance that replicator takes forever to complete this api with mode ReplicaSetQuarumMode::All
/// since client/user can keep writing and advancing the committed LSN, but for it most likely would not
/// stall ReplicaSetQuarumMode::Write.
/// stall in mode ReplicaSetQuarumMode::Write.
/// In other cases when client write is not impacted (like secondary restart),
/// SF may call this api only once with write status granted.
///
/// Implementor should not assume when this is called in relation to other api calls,
/// but instead follow the semantics of what catchup should do.
Expand Down
Loading