Change safe APIs to return mssf Error #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarTHZhang
approved these changes
Jan 23, 2025
youyuanwu
deleted the
users/youyuanwu/change-safe-api-to-use-mssf-Error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mssf Error can be converted to ErrorCode enum easily and user app can check the enum to determine why API failed.
Raw api returns windows_core::Error and typically user converts to mssf Error all the time after mssf API call. This PR changes the return time of all safe APIs to mssf Error so it is easy to handle failures, and it displays human readable messages.
Renamed FabricError to Error and this is the mssf Error we will use. Renamed FabricErrorCode to ErrorCode since it is clear.
One part of this change that requires careful review is the Bridge layer code where the ctx from Begin and End functions are not type checked but casted. I checked them manually.