-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: duplicate prompt messages #585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@roel4ez thanks for the PR and apologies for the late reply. I am ok with the approach, feel free to apply to the rest of the commands. |
marianan
reviewed
Oct 4, 2022
marianan
reviewed
Oct 4, 2022
marianan
reviewed
Oct 4, 2022
marianan
requested changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
marianan
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This checklist is used to make sure that common guidelines for a pull request are followed.
General guidelines
Description
Fixes #558
hi @marianan - This PR includes a commit to showcase the removal of the duplicate prompt message (only for subscription list right now). Let me know if you are ok with using this approach, and then I will work out the rest of the duplicate prompts.
Additional information
The problem seems to be that the method that sets the defaults is the one printing messages and when the
prompt
option is also set for the parameter, the default function gets called twice (see code).The solution used here is to prompt the user in the default method instead of using the
prompt
click option.Thanks @beandrad for the help